Skip to content

Chore: Migrate REST API - leaveRoom to Typescript #3833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dnlsilva merged 3 commits into from
Mar 7, 2022
Merged

Chore: Migrate REST API - leaveRoom to Typescript #3833

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f2ef64c
chore: add rest api type
dnlsilva Mar 4, 2022
d079edf
remove any
dnlsilva Mar 4, 2022
46d1973
Merge branch 'develop' into chore/leave-rest-api
dnlsilva Mar 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions app/definitions/rest/v1/channels.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,4 +52,7 @@ export type ChannelsEndpoints = {
'channels.convertToTeam': {
POST: (params: { channelId: string; channelName: string }) => { team: ITeam };
};
'channels.leave': {
POST: (params: { roomId: string }) => {};
};
};
3 changes: 3 additions & 0 deletions app/definitions/rest/v1/groups.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,4 +46,7 @@ export type GroupsEndpoints = {
'groups.convertToTeam': {
POST: (params: { roomId: string; roomName: string }) => { team: ITeam };
};
'groups.leave': {
POST: (params: { roomId: string }) => {};
};
};
3 changes: 3 additions & 0 deletions app/definitions/rest/v1/im.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,4 +38,7 @@ export type ImEndpoints = {
messages: IMessageFromServer[];
};
};
'im.leave': {
POST: (params: { roomId: string }) => {};
};
};
4 changes: 1 addition & 3 deletions app/lib/rocketchat/services/restApi.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -446,10 +446,8 @@ export const toggleBlockUser = (rid: string, blocked: string, block: boolean): P
return sdk.methodCallWrapper('unblockUser', { rid, blocked });
};

export const leaveRoom = (roomId: string, t: RoomTypes): any =>
export const leaveRoom = (roomId: string, t: RoomTypes) =>
// RC 0.48.0
// TODO: missing definitions from server
// @ts-ignore
sdk.post(`${roomTypeToApiType(t)}.leave`, { roomId });

export const deleteRoom = (roomId: string, t: RoomTypes): any =>
Expand Down