Skip to content

[FIX] Condensed layout cutting text on smaller text sizes #3831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
diegolmello merged 2 commits into from
Mar 7, 2022
Merged

[FIX] Condensed layout cutting text on smaller text sizes #3831

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eb737fa
Remove unnecessary padding and lineHeights
diegolmello Mar 4, 2022
8b354eb
Update tests
diegolmello Mar 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions app/presentation/RoomItem/Wrapper.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,7 @@ const Wrapper = ({ accessibilityLabel, theme, children, displayMode, ...props }:
styles.centerContainer,
{
borderColor: themes[theme].separatorColor
},
displayMode === DisplayMode.Condensed && styles.condensedPaddingVertical
}
]}>
{children}
</View>
Expand Down
5 changes: 0 additions & 5 deletions app/presentation/RoomItem/styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,6 @@ export default StyleSheet.create<any>({
containerCondensed: {
height: ROW_HEIGHT_CONDENSED
},
condensedPaddingVertical: {
paddingVertical: 20
},
centerContainer: {
flex: 1,
paddingVertical: 10,
Expand All @@ -33,7 +30,6 @@ export default StyleSheet.create<any>({
title: {
flex: 1,
fontSize: 17,
lineHeight: 20,
...sharedStyles.textMedium
},
alert: {
Expand Down Expand Up @@ -67,7 +63,6 @@ export default StyleSheet.create<any>({
markdownText: {
flex: 1,
fontSize: 14,
lineHeight: 17,
...sharedStyles.textRegular
},
avatar: {
Expand Down
22 changes: 11 additions & 11 deletions storybook/stories/__snapshots__/RoomItem.storyshot
View file
Open in desktop

Large diffs are not rendered by default.