Skip to content

Chore: Migrate REST API - deleteMessage to TS #3802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gerzonc merged 5 commits into from
Mar 2, 2022
Merged

Chore: Migrate REST API - deleteMessage to TS #3802

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4bec55e
migrate deleteMessage to ts
gerzonc Mar 1, 2022
1ef7329
remove: success field from `chats.delete` return
gerzonc Mar 2, 2022
71d8bb5
update: `ts` type
gerzonc Mar 2, 2022
84fb2e9
Merge branch 'develop' into chore.deletemessage-to-ts
gerzonc Mar 2, 2022
785bf8b
Merge branch 'develop' into chore.deletemessage-to-ts
gerzonc Mar 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions app/definitions/rest/v1/chat.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,4 +32,12 @@ export type ChatEndpoints = {
total: number;
}>;
};
'chat.delete': {
POST: (params: { msgId: string; roomId: string }) => {
_id: string;
ts: Date;
Comment thread
gerzonc marked this conversation as resolved.
Outdated
message: Pick<IMessage, '_id' | 'rid' | 'u'>;
success: boolean;
Comment thread
gerzonc marked this conversation as resolved.
Outdated
};
};
};
4 changes: 1 addition & 3 deletions app/lib/rocketchat/services/restApi.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,10 +258,8 @@ export const joinRoom = (roomId: string, joinCode: string, type: 'c' | 'p'): any
return sdk.post('channels.join', { roomId, joinCode });
};

export const deleteMessage = (messageId: string, rid: string): any =>
export const deleteMessage = (messageId: string, rid: string) =>
// RC 0.48.0
// TODO: missing definitions from server
// @ts-ignore
sdk.post('chat.delete', { msgId: messageId, roomId: rid });

export const markAsUnread = ({ messageId }: { messageId: string }): any =>
Expand Down