Skip to content

Chore: Migrate REST API - convertTeamToChannel to TS #3800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gerzonc merged 5 commits into from
Mar 2, 2022
Merged

Chore: Migrate REST API - convertTeamToChannel to TS #3800

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fd36d3f
migrate convertTeamToChannel to ts
gerzonc Mar 1, 2022
6db720a
Merge branch 'develop' into chore.convert2channel-to-ts
gerzonc Mar 2, 2022
ce49dfe
remove: `success` from `teams.convertToChannel` return
gerzonc Mar 2, 2022
e9a9c5d
Merge branch 'develop' into chore.convert2channel-to-ts
gerzonc Mar 2, 2022
c926c6e
Merge branch 'develop' into chore.convert2channel-to-ts
gerzonc Mar 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions app/definitions/rest/v1/teams.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,7 @@ export type TeamsEndpoints = {
'teams.removeRoom': {
POST: (params: { roomId: string; teamId: string }) => { room: IRoom };
};
'teams.convertToChannel': {
POST: (params: { teamId: string; roomsToRemove?: string[] }) => { success: boolean };
Comment thread
gerzonc marked this conversation as resolved.
Outdated
};
};
4 changes: 1 addition & 3 deletions app/lib/rocketchat/services/restApi.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,13 +237,11 @@ export const convertChannelToTeam = ({ rid, name, type }: { rid: string; name: s
return sdk.post(type === 'c' ? 'channels.convertToTeam' : 'groups.convertToTeam', params);
};

export const convertTeamToChannel = ({ teamId, selected }: { teamId: string; selected: string[] }): any => {
export const convertTeamToChannel = ({ teamId, selected }: { teamId: string; selected: string[] }) => {
const params = {
teamId,
...(selected.length && { roomsToRemove: selected })
};
// TODO: missing definitions from server
// @ts-ignore
return sdk.post('teams.convertToChannel', params);
};

Expand Down