Skip to content

Chore: Migrate REST API - removeTeamMember to TS #3799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gerzonc merged 5 commits into from
Mar 2, 2022
Merged

Chore: Migrate REST API - removeTeamMember to TS #3799

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3a720e8
migrate removeMember rest api to ts
gerzonc Mar 1, 2022
79dd071
Merge branch 'develop' into chore.removeteammember-to-ts
gerzonc Mar 2, 2022
dccbb66
Merge branch 'develop' into chore.removeteammember-to-ts
gerzonc Mar 2, 2022
3b9fbb4
Update teams.ts
gerzonc Mar 2, 2022
26b50db
Merge branch 'develop' into chore.removeteammember-to-ts
gerzonc Mar 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions app/definitions/rest/v1/teams.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,7 @@ export type TeamsEndpoints = {
'teams.removeRoom': {
POST: (params: { roomId: string; teamId: string }) => { room: IRoom };
};
'teams.removeMember': {
POST: (params: { teamId: string; userId: string; rooms?: string[] }) => {};
};
};
4 changes: 1 addition & 3 deletions app/lib/rocketchat/services/restApi.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,10 +191,8 @@ export const leaveTeam = ({ teamId, rooms }: { teamId: string; rooms: string[] }
...(rooms?.length && { rooms })
});

export const removeTeamMember = ({ teamId, userId, rooms }: { teamId: string; userId: string; rooms: string[] }): any =>
export const removeTeamMember = ({ teamId, userId, rooms }: { teamId: string; userId: string; rooms: string[] }) =>
// RC 3.13.0
// TODO: missing definitions from server
// @ts-ignore
sdk.post('teams.removeMember', {
teamId,
userId,
Expand Down