Skip to content

Chore: Migrate REST API - addRoomsToTeam to TS #3797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gerzonc merged 4 commits into from
Mar 2, 2022
Merged

Chore: Migrate REST API - addRoomsToTeam to TS #3797

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
51a6b19
migrate addRooms to ts
gerzonc Mar 1, 2022
1b4e422
Merge branch 'develop' into chore.addroomstoteam-to-ts
gerzonc Mar 2, 2022
4531c26
remove: `success` from `teams.addRooms` return
gerzonc Mar 2, 2022
202163d
Merge branch 'develop' into chore.addroomstoteam-to-ts
gerzonc Mar 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions app/definitions/rest/v1/teams.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,7 @@ export type TeamsEndpoints = {
'teams.removeRoom': {
POST: (params: { roomId: string; teamId: string }) => { room: IRoom };
};
'teams.addRooms': {
POST: (params: { teamId: string; rooms: string[] }) => { rooms: IRoom[] };
};
};
4 changes: 1 addition & 3 deletions app/lib/rocketchat/services/restApi.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,10 +171,8 @@ export const createTeam = ({
// @ts-ignore
return sdk.post('teams.create', params);
};
export const addRoomsToTeam = ({ teamId, rooms }: { teamId: string; rooms: string[] }): any =>
export const addRoomsToTeam = ({ teamId, rooms }: { teamId: string; rooms: string[] }) =>
// RC 3.13.0
// TODO: missing definitions from server
// @ts-ignore
sdk.post('teams.addRooms', { teamId, rooms });

export const removeTeamRoom = ({ roomId, teamId }: { roomId: string; teamId: string }) =>
Expand Down