Skip to content

Chore: Migrate REST API - createTeam to TS #3788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gerzonc merged 4 commits into from
Mar 2, 2022
Merged

Chore: Migrate REST API - createTeam to TS #3788

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5686cd6
create teams.create migration to ts
gerzonc Feb 28, 2022
fd49cc0
Merge branch 'develop' into chore.migrate-createteam-to-ts
gerzonc Mar 2, 2022
aad2e7e
remove: `success` from `teams.create` return
gerzonc Mar 2, 2022
13f427c
Merge branch 'develop' into chore.migrate-createteam-to-ts
gerzonc Mar 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions app/definitions/rest/v1/teams.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,16 @@
import { IRoom } from '../../IRoom';
import { ITeam, TEAM_TYPE } from '../../ITeam';

export type TeamsEndpoints = {
'teams.removeRoom': {
POST: (params: { roomId: string; teamId: string }) => { room: IRoom };
};
'teams.create': {
POST: (params: {
name: string;
users: string[];
type: TEAM_TYPE;
room: { readOnly: boolean; extraData: { broadcast: boolean; encrypted: boolean } };
}) => { team: ITeam };
};
};
4 changes: 1 addition & 3 deletions app/lib/rocketchat/services/restApi.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ export const createTeam = ({
readOnly: boolean;
broadcast: boolean;
encrypted: boolean;
}): any => {
}) => {
const params = {
name,
users,
Expand All @@ -167,8 +167,6 @@ export const createTeam = ({
}
};
// RC 3.13.0
// TODO: missing definitions from server
// @ts-ignore
return sdk.post('teams.create', params);
};
export const addRoomsToTeam = ({ teamId, rooms }: { teamId: string; rooms: string[] }): any =>
Expand Down