Skip to content

[FIX] Display emojis when used just after the text without any space#3713

Open
try-catch-stack wants to merge 1 commit into
RocketChat:developfrom
try-catch-stack:fix.emojis-in-message
Open

[FIX] Display emojis when used just after the text without any space#3713
try-catch-stack wants to merge 1 commit into
RocketChat:developfrom
try-catch-stack:fix.emojis-in-message

Conversation

@try-catch-stack

Copy link
Copy Markdown
Contributor

Proposed changes

The emojis used just after the text without any space are not rendered as emojis.

Issue(s)

How to test or reproduce

Send a message with some text and use an emoji just after the text like Text:smiley: You will see that the emoji will not be rendered .

Screenshots

Types of changes

Before:
emoji-before

After:
emoji-after

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@try-catch-stack

Copy link
Copy Markdown
Contributor Author

No issues with the markdown table this time @diegolmello . Seems the StoryShot issue was solved by this PR #3677 .

@diegolmello

Copy link
Copy Markdown
Member

Let's review after we merge #3558

@try-catch-stack

Copy link
Copy Markdown
Contributor Author

Sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants