Skip to content

[FIX] Messages read after a lack of connection #3685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
reinaldonetof wants to merge 19 commits into from
Closed

[FIX] Messages read after a lack of connection #3685

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
3410302
[FIX] Messages read after a lack of connection
reinaldonetof Feb 2, 2022
f4407dd
refactor handleConnection
reinaldonetof Feb 3, 2022
c84cbdb
minor tweak
reinaldonetof Feb 3, 2022
8989ff0
tweaks
reinaldonetof Feb 3, 2022
c4c6c7a
Merge branch 'develop' into fix.messages-not-read
reinaldonetof Feb 3, 2022
cb84623
Merge branch 'fix.messages-not-read' of https://github.com/RocketChat…
reinaldonetof Feb 3, 2022
8bac030
refactor the call to other place
reinaldonetof Feb 3, 2022
cb0f176
using the same logic as handleMessageReceived
reinaldonetof Feb 3, 2022
3d72512
refactor handleConnection
reinaldonetof Feb 3, 2022
f360bdf
minor tweak
reinaldonetof Feb 9, 2022
b2bff3b
[FIX] Messages read after a lack of connection
reinaldonetof Feb 2, 2022
dae0c66
refactor handleConnection
reinaldonetof Feb 3, 2022
0d7d58a
minor tweak
reinaldonetof Feb 3, 2022
dac73e7
tweaks
reinaldonetof Feb 3, 2022
5ce1585
refactor the call to other place
reinaldonetof Feb 3, 2022
b066c3e
using the same logic as handleMessageReceived
reinaldonetof Feb 3, 2022
a45584a
refactor handleConnection
reinaldonetof Feb 3, 2022
d1cf19f
minor tweak
reinaldonetof Feb 9, 2022
19735ad
Merge branch 'fix.messages-not-read' of https://github.com/RocketChat…
reinaldonetof Feb 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions app/lib/methods/subscriptions/room.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,7 @@ export default class RoomSubscription {
handleConnection = () => {
reduxStore.dispatch(clearUserTyping());
RocketChat.loadMissedMessages({ rid: this.rid }).catch(e => console.log(e));
Comment thread
reinaldonetof marked this conversation as resolved.
Outdated
RocketChat.subscriptionRead(this.rid);
Comment thread
reinaldonetof marked this conversation as resolved.
Outdated
};

handleNotifyRoomReceived = protectedFunction(ddpMessage => {
Expand Down
3 changes: 3 additions & 0 deletions app/lib/rocketchat.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1057,6 +1057,9 @@ const RocketChat = {
}
return this.post('subscriptions.read', { rid: roomId });
},
subscriptionRead(roomId) {

@diegolmello diegolmello Feb 3, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need this. We should call RoomServices.readMessages

return this.post('subscriptions.read', { rid: roomId });
},
async getRoomMembers({ rid, allUsers, roomType, type, filter, skip = 0, limit = 10 }) {
const serverVersion = reduxStore.getState().server.version;
if (compareServerVersion(serverVersion, '3.16.0', methods.greaterThanOrEqualTo)) {
Expand Down