Skip to content

[NEW] Add sorting functionality in directory page and some improvements#3653

Closed
try-catch-stack wants to merge 1 commit into
RocketChat:developfrom
try-catch-stack:directory-sort
Closed

[NEW] Add sorting functionality in directory page and some improvements#3653
try-catch-stack wants to merge 1 commit into
RocketChat:developfrom
try-catch-stack:directory-sort

Conversation

@try-catch-stack

@try-catch-stack try-catch-stack commented Jan 26, 2022

Copy link
Copy Markdown
Contributor

Proposed changes

  • Added a header in Directory page which allows the user to sort channels/teams/users by factors like member count , name etc.
  • Also , previously , the dropdown menu did not close automatically on selecting any option which was not a good experience.
  • The PR also includes some visual updates like adding a Featured chip in front of featured channels.

Issue(s)

How to test or reproduce

Screenshots

directory.mp4

Light theme:
directory-light-theme

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@ankar84

ankar84 commented Jan 27, 2022

Copy link
Copy Markdown
Contributor

Looks very useful!

@dnlsilva

Copy link
Copy Markdown
Contributor

As I said in the other PR, visual changes we have to confirm with our UX team, as soon as I have a feedback I'll let you know. @try-catch-stack

@try-catch-stack

Copy link
Copy Markdown
Contributor Author

Sure @GleidsonDaniel
Will be waiting for the feedback!

@diegolmello

Copy link
Copy Markdown
Member

It might take a while to get to you on this one.
That kind of sorting is not the usual pattern on mobile.
It's usually done with a sorting dropdown instead.
But again, it's something the UX team should take a look first.

@try-catch-stack

Copy link
Copy Markdown
Contributor Author

Sure, no problem (:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants