Skip to content

[FIX] makeThreadName asserting undefined as non-null #3628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
diegolmello merged 3 commits into from
Jan 19, 2022
Merged

[FIX] makeThreadName asserting undefined as non-null #3628

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3c4197c
[FIX] makeThreadName checking undefined object
reinaldonetof Jan 18, 2022
d2d978d
minor tweak
reinaldonetof Jan 18, 2022
717798b
Merge branch 'develop' into fix.make-thread-name
diegolmello Jan 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/utils/room.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,6 @@ export const getBadgeColor = ({
};

export const makeThreadName = (messageRecord: { id?: string; msg?: string; attachments?: IAttachment[] }): string | undefined =>
messageRecord.msg || messageRecord.attachments![0].title;
messageRecord.msg || messageRecord?.attachments?.[0]?.title;

export const isTeamRoom = ({ teamId, joined }: { teamId: string; joined: boolean }): boolean => !!teamId && joined;