Skip to content

[FIX] RoomInfoView displaying different info depending on the origin #3586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
diegolmello merged 3 commits into from
Jan 12, 2022
Merged

[FIX] RoomInfoView displaying different info depending on the origin #3586

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4a0b7ff
[FIX] RoomInfoView displaying different info depending on the origin
reinaldonetof Jan 5, 2022
8d43769
fix: fix setState logic because side-effects
dnlsilva Jan 7, 2022
a356e45
Merge branch 'develop' into fix.same-info-roomactionview
diegolmello Jan 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 20 additions & 6 deletions app/views/RoomInfoView/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,6 +178,14 @@ class RoomInfoView extends React.Component {
}
};

parseRoles = roleArray =>
Promise.all(
roleArray.map(async role => {
const description = await this.getRoleDescription(role);
return description;
})
);

loadUser = async () => {
const { room, roomUser } = this.state;

Expand All @@ -189,19 +197,25 @@ class RoomInfoView extends React.Component {
const { user } = result;
const { roles } = user;
if (roles && roles.length) {
user.parsedRoles = await Promise.all(
roles.map(async role => {
const description = await this.getRoleDescription(role);
return description;
})
);
user.parsedRoles = await this.parseRoles(roles);
}

this.setState({ roomUser: user });
}
} catch {
// do nothing
}
} else {
try {
const { roles } = roomUser;
if (roles && roles.length) {
roomUser.parsedRoles = await this.parseRoles(roles);
Comment thread
dnlsilva marked this conversation as resolved.
Outdated
}

this.setState({ roomUser });
} catch (e) {
// do nothing
}
}
};

Expand Down