-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Chore: Migrate ThreadMessagesView to Typescript #3538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 5 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
d3dbdb2
Chore: Migrate ThreadMessagesView to Typescript
reinaldonetof 931ef95
index migration
reinaldonetof 49b2eb6
Merge branch 'develop' into chore.ts-threadmessagesview
reinaldonetof 093a630
minor tweak
reinaldonetof 23c475f
minor tweak
reinaldonetof 47f4df3
tweak subscribeMessages
reinaldonetof 7107f94
delete TODO
reinaldonetof 9ccf816
new definitions
reinaldonetof 58bd5fd
refactor threadMessageView
reinaldonetof 6ca6cb5
renderItem IthreadModel
reinaldonetof fd22182
minor tweak
reinaldonetof b0385f5
minor tweak
reinaldonetof affb9da
minor tweak
reinaldonetof 5a58fa5
Merge branch 'develop' into chore.ts-threadmessagesview
reinaldonetof dc40b47
Merge branch 'develop' into chore.ts-threadmessagesview
AlexAlexandre 6a9dfbe
refactor: update new types and interfaces for use ISubscription
AlexAlexandre 6010861
Merge branch 'develop' into chore.ts-threadmessagesview
diegolmello File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 changes: 7 additions & 8 deletions
15
...ssagesView/Dropdown/DropdownItemFilter.js → ...sagesView/Dropdown/DropdownItemFilter.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,17 +1,16 @@ | ||
| import React from 'react'; | ||
| import PropTypes from 'prop-types'; | ||
|
|
||
| import I18n from '../../../i18n'; | ||
| import DropdownItem from './DropdownItem'; | ||
|
|
||
| const DropdownItemFilter = ({ currentFilter, value, onPress }) => ( | ||
| interface IDropdownItemFilter { | ||
| currentFilter: string; | ||
| value: string; | ||
| onPress: (value: string) => void; | ||
| } | ||
|
|
||
| const DropdownItemFilter = ({ currentFilter, value, onPress }: IDropdownItemFilter): JSX.Element => ( | ||
| <DropdownItem text={I18n.t(value)} iconName={currentFilter === value ? 'check' : null} onPress={() => onPress(value)} /> | ||
| ); | ||
|
|
||
| DropdownItemFilter.propTypes = { | ||
| currentFilter: PropTypes.string, | ||
| value: PropTypes.string, | ||
| onPress: PropTypes.func | ||
| }; | ||
|
|
||
| export default DropdownItemFilter; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| export enum FILTER { | ||
|
reinaldonetof marked this conversation as resolved.
Outdated
|
||
| ALL = 'All', | ||
| FOLLOWING = 'Following', | ||
| UNREAD = 'Unread' | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.