Skip to content

Remove NewServerView from single-server#3475

Merged
diegolmello merged 1 commit into
RocketChat:single-serverfrom
jacotec:single-server
Nov 3, 2021
Merged

Remove NewServerView from single-server#3475
diegolmello merged 1 commit into
RocketChat:single-serverfrom
jacotec:single-server

Conversation

@jacotec

@jacotec jacotec commented Oct 30, 2021

Copy link
Copy Markdown
Contributor

Fixes the additional general onboarding screen for the Rocket.Chat app being available for selection in the single-server build.

Proposed changes

In the single server build there was the ability to move back from the single server onboarding screeen to the general Rocket Chat onboarding screen with a "back" button.

This is removed with this PR.

image

image

Issue(s)

No Github issue opened, referring to chat with Diego Mello: https://open.rocket.chat/channel/react-native?msg=yvzfXMpsMZChrXXAG

How to test or reproduce

Screenshots

See above

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

Fixes the additional general onboarding screen for the Rocket.Chat app being available for selection in the single-server build.
@lgtm-com

lgtm-com Bot commented Oct 30, 2021

Copy link
Copy Markdown

This pull request introduces 1 alert when merging bbd31bd into 83b4164 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@diegolmello diegolmello changed the title Update OutsideStack.js Remove NewServerView from single-server Nov 3, 2021
@diegolmello diegolmello merged commit 85d4ec0 into RocketChat:single-server Nov 3, 2021
ivnxyz pushed a commit to NextiaDev/Rocket.Chat.ReactNative that referenced this pull request May 26, 2023
Fixes the additional general onboarding screen for the Rocket.Chat app being available for selection in the single-server build.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants