Skip to content

[FIX] Preview rendering for threaded messages#3463

Closed
gerzonc wants to merge 8 commits into
developfrom
fix.new-markdown-preview
Closed

[FIX] Preview rendering for threaded messages#3463
gerzonc wants to merge 8 commits into
developfrom
fix.new-markdown-preview

Conversation

@gerzonc

@gerzonc gerzonc commented Oct 26, 2021

Copy link
Copy Markdown
Contributor

Proposed changes

Fixes how to render preview messages for threaded messages with the new message parser.

Issue(s)

How to test or reproduce

  1. Create a thread
  2. Send different kind of messages (links, mention someone else, mention yourself, etc.) to the thread with the setting Also send to channel enabled.

No message should render with markdown styling

Screenshots

Before After
image image

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@gerzonc gerzonc self-assigned this Oct 26, 2021
@gerzonc gerzonc marked this pull request as ready for review October 26, 2021 18:10
@diegolmello

Copy link
Copy Markdown
Member

Closed in favor of #3465

@diegolmello diegolmello deleted the fix.new-markdown-preview branch October 27, 2021 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants