Skip to content

[FIX] Different token types inside list items#3458

Merged
diegolmello merged 5 commits into
developfrom
fix.md-list
Oct 27, 2021
Merged

[FIX] Different token types inside list items#3458
diegolmello merged 5 commits into
developfrom
fix.md-list

Conversation

@diegolmello

@diegolmello diegolmello commented Oct 22, 2021 •
edited
Loading

Copy link
Copy Markdown
Member

Proposed changes

Issue(s)

How to test or reproduce

Screenshots

Before After
image image

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@diegolmello diegolmello marked this pull request as ready for review October 26, 2021 13:34
@diegolmello diegolmello merged commit b2db7c8 into develop Oct 27, 2021
@diegolmello diegolmello deleted the fix.md-list branch October 27, 2021 13:13
ivnxyz pushed a commit to NextiaDev/Rocket.Chat.ReactNative that referenced this pull request May 26, 2023
@diegolmello @gerzonc
[FIX] Different token types inside list items (RocketChat#3458)
da3e28c 
* Fix different token types inside list items

* Fixing more styles

* Update tests

Co-authored-by: Gerzon Z <gerzonc@icloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@diegolmello @gerzonc