[FIX] WatermelonDB linking on iOS#3450
Merged
Merged
Conversation
AlexAlexandre
left a comment
Contributor
There was a problem hiding this comment.
@diegolmello I already reviewed and tested, looks likes everything is ok and works fine.
But, I'm not very sure about some changes at ios/RocketChatRN.xcodeproj/project.pbxproj
Can you take a look please ?
diegolmello
approved these changes
Oct 26, 2021
ivnxyz
pushed a commit
to NextiaDev/Rocket.Chat.ReactNative
that referenced
this pull request
May 26, 2023
* unlink watermelondb * Minor change on archs Co-authored-by: Diego Mello <diegolmello@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Unlinks WatermelonDB in order to be able to autolink it.
Reference: https://github.com/react-native-community/cli/blob/master/docs/autolinking.md#what-do-i-need-to-have-in-my-package-to-make-it-work
Issue(s)
How to test or reproduce
We should check that the app is working properly
Screenshots
Types of changes
Checklist
Further comments