Skip to content

[FIX] WatermelonDB linking on iOS#3450

Merged
diegolmello merged 3 commits into
developfrom
chore.autolink-watermelondb
Oct 26, 2021
Merged

[FIX] WatermelonDB linking on iOS#3450
diegolmello merged 3 commits into
developfrom
chore.autolink-watermelondb

Conversation

@gerzonc

@gerzonc gerzonc commented Oct 20, 2021

Copy link
Copy Markdown
Contributor

Proposed changes

Unlinks WatermelonDB in order to be able to autolink it.

Reference: https://github.com/react-native-community/cli/blob/master/docs/autolinking.md#what-do-i-need-to-have-in-my-package-to-make-it-work

Issue(s)

How to test or reproduce

We should check that the app is working properly

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@gerzonc gerzonc self-assigned this Oct 20, 2021
@gerzonc gerzonc changed the title Chore: Autolink WatermelonDB Chore: Autolinking WatermelonDB Oct 20, 2021
@gerzonc gerzonc marked this pull request as ready for review October 20, 2021 23:48

@AlexAlexandre AlexAlexandre left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@diegolmello I already reviewed and tested, looks likes everything is ok and works fine.
But, I'm not very sure about some changes at ios/RocketChatRN.xcodeproj/project.pbxproj
Can you take a look please ?

@diegolmello diegolmello changed the title Chore: Autolinking WatermelonDB [FIX] WatermelonDB linking on iOS Oct 26, 2021
@diegolmello diegolmello merged commit e98caea into develop Oct 26, 2021
@diegolmello diegolmello deleted the chore.autolink-watermelondb branch October 26, 2021 16:35
ivnxyz pushed a commit to NextiaDev/Rocket.Chat.ReactNative that referenced this pull request May 26, 2023
* unlink watermelondb

* Minor change on archs

Co-authored-by: Diego Mello <diegolmello@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants