Skip to content

Chore: Migrate AuthenticationWebView to Typescript#3441

Merged
diegolmello merged 4 commits into
developfrom
chore.ts-authenticationwebview
Oct 20, 2021
Merged

Chore: Migrate AuthenticationWebView to Typescript#3441
diegolmello merged 4 commits into
developfrom
chore.ts-authenticationwebview

Conversation

@reinaldonetof

@reinaldonetof reinaldonetof commented Oct 14, 2021

Copy link
Copy Markdown
Contributor

Proposed changes

Issue(s)

How to test or reproduce

  • You need to connect to any workspace, you could test with the open.rocket.chat
  • Then you must click on any oAuth authentication, as: github, gitlab... except the goole oAuth
  • And should be open a web view in-app to do the authentication

Screenshots

Types of changes

  • [] Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@reinaldonetof reinaldonetof self-assigned this Oct 14, 2021
AlexAlexandre
AlexAlexandre suggested changes Oct 15, 2021
View reviewed changes
Comment thread app/views/AuthenticationWebView.tsx Outdated
Comment thread app/views/AuthenticationWebView.tsx Outdated
AlexAlexandre
AlexAlexandre approved these changes Oct 18, 2021
View reviewed changes

@AlexAlexandre AlexAlexandre left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@diegolmello diegolmello merged commit 744893f into develop Oct 20, 2021
@diegolmello diegolmello deleted the chore.ts-authenticationwebview branch October 20, 2021 18:00
ivnxyz pushed a commit to NextiaDev/Rocket.Chat.ReactNative that referenced this pull request May 26, 2023
@reinaldonetof
Chore: Migrate AuthenticationWebView to Typescript (RocketChat#3441)
0021c10 
* Chore: Migrate AuthenticationWebView to Typescript

* minor tweak

* added @types/url-parser
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@AlexAlexandre AlexAlexandre AlexAlexandre approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@reinaldonetof reinaldonetof

Labels

🚚 chore

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@reinaldonetof @AlexAlexandre @diegolmello