Skip to content

[FIX] Cannot read property 'error' of undefined when creating a channel#3437

Merged
diegolmello merged 2 commits into
developfrom
fix.error-undefined-saga-create-channel
Oct 26, 2021
Merged

[FIX] Cannot read property 'error' of undefined when creating a channel#3437
diegolmello merged 2 commits into
developfrom
fix.error-undefined-saga-create-channel

Conversation

@reinaldonetof

@reinaldonetof reinaldonetof commented Oct 10, 2021

Copy link
Copy Markdown
Contributor

Proposed changes

I couldn't reproduce the error, but checking the TypeError from Bugsnag, might be solved by adding ? when inferring the error from data.

Issue(s)

How to test or reproduce

Researching in Bugsnag I found some errors:

  • occurred on a server with the 3.8.5 version, while was trying to create a channel.
  • Another error was happening when is trying to create a team on the 3.18.1 server version.
  • And occurred sometimes, but less than others, with the open.rocket.chat when tried to Select users while was Creating a channel.

These errors I found with the Bugsnag, but I couldn't reproduce anyone.

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@reinaldonetof reinaldonetof self-assigned this Oct 10, 2021
@AlexAlexandre AlexAlexandre self-requested a review October 18, 2021 18:10

@AlexAlexandre AlexAlexandre left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will be necessary update the how to test or reproduce section.
Create a flow to create channel, ask Levy to try reproduce the error on production app.
And then check your correction.

@AlexAlexandre AlexAlexandre self-requested a review October 19, 2021 15:34

@AlexAlexandre AlexAlexandre left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@diegolmello diegolmello merged commit 72d5088 into develop Oct 26, 2021
@diegolmello diegolmello deleted the fix.error-undefined-saga-create-channel branch October 26, 2021 13:40
ivnxyz pushed a commit to NextiaDev/Rocket.Chat.ReactNative that referenced this pull request May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants