Skip to content

Chore: Migrate SettingsView to TypeScript#3430

Merged
diegolmello merged 4 commits into
developfrom
chore.migrate-settingsview-ts
Oct 20, 2021
Merged

Chore: Migrate SettingsView to TypeScript#3430
diegolmello merged 4 commits into
developfrom
chore.migrate-settingsview-ts

Conversation

@gerzonc

@gerzonc gerzonc commented Oct 6, 2021

Copy link
Copy Markdown
Contributor

Proposed changes

Issue(s)

How to test or reproduce

On Settings:

  1. Check that each button works properly
  2. Check that log out and clean cache are working properly

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

Needs utils to be migrated to TypeScript

Comment thread app/views/SettingsView/index.tsx Outdated

@AlexAlexandre AlexAlexandre left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@diegolmello diegolmello merged commit 30a84a9 into develop Oct 20, 2021
@diegolmello diegolmello deleted the chore.migrate-settingsview-ts branch October 20, 2021 17:56
ivnxyz pushed a commit to NextiaDev/Rocket.Chat.ReactNative that referenced this pull request May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants