Skip to content

[IMPROVE] Pull down to refresh read receipts#3427

Merged
diegolmello merged 7 commits into
RocketChat:developfrom
wreiske:patch-1
Oct 20, 2021
Merged

[IMPROVE] Pull down to refresh read receipts#3427
diegolmello merged 7 commits into
RocketChat:developfrom
wreiske:patch-1

Conversation

@wreiske

@wreiske wreiske commented Oct 5, 2021

Copy link
Copy Markdown
Contributor

Proposed changes

This PR adds the ability for users to pull down to refresh read receipts. Currently, to refresh read receipts you have to close out, long press on a message, scroll the popup and find "Read Receipts", tap it, and repeat. This PR makes it simple to refresh by pulling down to refresh.

How to test or reproduce

  • Enable read receipts on server
  • Send a message and check read receipts
  • Read the message as the other user
  • Pull down to refresh list
  • List should be updated

Screenshots

Screen_Recording_20211005-150515_.DEBUG.RocketChat.Experimental.mp4

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

This commit introduces a new feature to allow users to pull down to refresh read receipts.
This adds support for the pull-down refresh to work when there are no read receipts yet.
@debdutdeb debdutdeb requested a review from diegolmello October 5, 2021 23:35

@diegolmello diegolmello left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@diegolmello diegolmello changed the title [FEATURE] Pull down to refresh read receipts [IMPROVE] Pull down to refresh read receipts Oct 8, 2021
@diegolmello diegolmello merged commit 467a1a5 into RocketChat:develop Oct 20, 2021
ivnxyz pushed a commit to NextiaDev/Rocket.Chat.ReactNative that referenced this pull request May 26, 2023
* [FEATURE] Pull down to refresh read receipts

This commit introduces a new feature to allow users to pull down to refresh read receipts.

* Support pull down to refresh when we renderEmpty

This adds support for the pull-down refresh to work when there are no read receipts yet.

* Removed extra new lines added while debugging.

* Minor polishing

Co-authored-by: Diego Mello <diegolmello@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants