Skip to content

Chore: Migrate InviteUsersView to Typescript#3426

Merged
diegolmello merged 7 commits into
developfrom
chore.ts-inviteuser
Oct 20, 2021
Merged

Chore: Migrate InviteUsersView to Typescript#3426
diegolmello merged 7 commits into
developfrom
chore.ts-inviteuser

Conversation

@reinaldonetof

@reinaldonetof reinaldonetof commented Oct 5, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

Proposed changes

Issue(s)

How to test or reproduce

  • You need to be an owner of a channel
  • Then go to Actions and click on Invite users

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@reinaldonetof reinaldonetof self-assigned this Oct 5, 2021
AlexAlexandre
AlexAlexandre suggested changes Oct 6, 2021
View reviewed changes
Comment thread app/containers/TextInput.tsx Outdated
Comment thread app/views/InviteUsersView/index.tsx Outdated
AlexAlexandre
AlexAlexandre approved these changes Oct 6, 2021
View reviewed changes

@AlexAlexandre AlexAlexandre left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@diegolmello

diegolmello commented Oct 6, 2021

Copy link
Copy Markdown
Member

@reinaldonetof Lint is failing

AlexAlexandre
AlexAlexandre approved these changes Oct 11, 2021
View reviewed changes

@AlexAlexandre AlexAlexandre left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@AlexAlexandre AlexAlexandre self-requested a review October 14, 2021 17:33
AlexAlexandre
AlexAlexandre approved these changes Oct 14, 2021
View reviewed changes

@AlexAlexandre AlexAlexandre left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@diegolmello diegolmello merged commit 7728997 into develop Oct 20, 2021
@diegolmello diegolmello deleted the chore.ts-inviteuser branch October 20, 2021 17:49
ivnxyz pushed a commit to NextiaDev/Rocket.Chat.ReactNative that referenced this pull request May 26, 2023
@reinaldonetof @AlexAlexandre
Chore: Migrate InviteUsersView to Typescript (RocketChat#3426)
554f23d 
* Chore: Migrate InviteUsersView to ts

* minor tweaks

* minor tweak

Co-authored-by: AlexAlexandre <alexalexandrejr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@AlexAlexandre AlexAlexandre AlexAlexandre approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@reinaldonetof reinaldonetof

Labels

🚚 chore 👀 needs review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@reinaldonetof @diegolmello @AlexAlexandre