Skip to content

Chore: Migrate RegisterView to TypeScript#3417

Merged
diegolmello merged 20 commits into
developfrom
chore.migrate-registerview-ts
Oct 20, 2021
Merged

Chore: Migrate RegisterView to TypeScript#3417
diegolmello merged 20 commits into
developfrom
chore.migrate-registerview-ts

Conversation

@gerzonc

@gerzonc gerzonc commented Oct 1, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

Proposed changes

Migrates RegisterView to TypeScript

Issue(s)

How to test or reproduce

On Register:

  1. Check that each input is working properly
  2. Check that button is working properly
  3. Check that register action is working properly

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@gerzonc gerzonc self-assigned this Oct 1, 2021
@gerzonc gerzonc changed the title Chore: Migrate RegisterView to TypeScript [CHORE] Migrate RegisterView to TypeScript Oct 4, 2021
@gerzonc gerzonc marked this pull request as ready for review October 4, 2021 16:27
@AlexAlexandre AlexAlexandre self-requested a review October 4, 2021 17:00
@gerzonc gerzonc changed the title [CHORE] Migrate RegisterView to TypeScript Chore: Migrate RegisterView to TypeScript Oct 5, 2021
@AlexAlexandre

AlexAlexandre commented Oct 11, 2021

Copy link
Copy Markdown
Contributor

@gerzonc Lint is failing

AlexAlexandre
AlexAlexandre approved these changes Oct 19, 2021
View reviewed changes

@AlexAlexandre AlexAlexandre left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@diegolmello diegolmello merged commit 839645e into develop Oct 20, 2021
@diegolmello diegolmello deleted the chore.migrate-registerview-ts branch October 20, 2021 17:53
ivnxyz pushed a commit to NextiaDev/Rocket.Chat.ReactNative that referenced this pull request May 26, 2023
@gerzonc @AlexAlexandre @diegolmello
Chore: Migrate RegisterView to TypeScript (RocketChat#3417)
feb9a52 
* start migration to typescript

* update interface for RegisterView and TextInput

* Update types TextInput

* Minor tweak

* Update TextInput interface

* Minor change

* Update FormContainer.tsx

* Minor tweaks

* style: adding ts-ignore to fix later

* Minor tweak

* update storyshots

* Update TextInput interface

* Minor tweak

* Update snapshots

Co-authored-by: AlexAlexandre <alexalexandrejr@gmail.com>
Co-authored-by: Diego Mello <diegolmello@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@AlexAlexandre AlexAlexandre AlexAlexandre approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@gerzonc gerzonc

Labels

🚚 chore 👀 needs review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gerzonc @AlexAlexandre @diegolmello