[NEW] Direct link to a threaded conversation#3406
Merged
Merged
Conversation
|
This pull request introduces 1 alert when merging b902058 into 5bb5d54 - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging 6206f75 into 5bb5d54 - view on LGTM.com new alerts:
|
diegolmello
reviewed
Oct 7, 2021
ivnxyz
pushed a commit
to NextiaDev/Rocket.Chat.ReactNative
that referenced
this pull request
May 26, 2023
* [FIX] deeplinking to thread * fix how to find threadId * tmid as route params jumpToThreaId * minor tweak * minor tweak on logic * E2E Test * minor tweak * wait for the return of the thread * Minor refactor * Fix e2e tests for docker * popToRoot when focused and there is a jumpToThread Co-authored-by: Diego Mello <diegolmello@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue(s)
Closes #3312
How to test or reproduce
Where do you want to open this link?Mobile application. But, if you are using a tablet as big as iPad Pro 11inch, you should click onDesktop application.Screenshots
Types of changes
direct-link.mp4
Checklist
Further comments