Skip to content

Conversation

@diegolmello
Copy link
Member

Proposed changes

After #3279, lint-staged stopped working.

Issue(s)

How to test or reproduce

  • Create a temp branch
  • Try to commit a change that should fail on a JS file
  • Try to commit a change that should fail on a TS file

Note: Don't run it with --no-verify as I did on #3279 😅

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

Copy link
Contributor

@AlexAlexandre AlexAlexandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@diegolmello diegolmello merged commit 201b84e into develop Sep 14, 2021
@diegolmello diegolmello deleted the chore.fix-precommit-hook branch September 14, 2021 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants