Skip to content

Conversation

@AlexAlexandre
Copy link
Contributor

@AlexAlexandre AlexAlexandre commented Sep 14, 2021

Proposed changes

The purpose of this PR it is migrate the view DirectoryView to typescript.

Issue(s)

N/A

How to test or reproduce

You can test the code running yarn lint or prettier-lint to check the code style too.

Screenshots

N/A

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

N/A

@lgtm-com
Copy link

lgtm-com bot commented Sep 14, 2021

This pull request introduces 1 alert when merging e4ec40a into 28d7a1b - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@AlexAlexandre AlexAlexandre changed the title Migrating the view DirectoryView to typescript Chore: Migrating the view DirectoryView to typescript Sep 15, 2021
@diegolmello diegolmello changed the title Chore: Migrating the view DirectoryView to typescript Chore: Migrate DirectoryView to Typescript Sep 15, 2021
Copy link
Member

@diegolmello diegolmello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@diegolmello diegolmello merged commit 5bc74c6 into develop Sep 15, 2021
@diegolmello diegolmello deleted the improvement.ts-migration.view.DirectoryView branch September 15, 2021 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants