[FIX] Black screen during Share

[cprice-kgi]

Proposed changes

Something about RNSplashScreen.hide is causing an issue here. I wrapped the call in a try/catch.

Issue(s)

#3088

How to test or reproduce

Try to share an image either from within the app or from an another application to the app. After investigation, I have found this issue appears only when the server has the mobile screen lock value enabled. If it is disabled, sharing will work fine. If enabled, the call to RNSplashScreen.hide will cause a black screen to appear, and the user is unable to proceed.

Screenshots

Types of changes

• [ x] Bugfix (non-breaking change which fixes an issue)
• Improvement (non-breaking change which improves a current function)
• New feature (non-breaking change which adds functionality)
• Documentation update (if none of the other choices apply)

Checklist

• [x ] I have read the CONTRIBUTING doc
• [ x] I have signed the CLA
• [ x] Lint and unit tests pass locally with my changes
• I have added tests that prove my fix is effective or that my feature works (if applicable)
• I have added necessary documentation (if applicable)
• Any dependent changes have been merged and published in downstream modules

Further comments

N/A

[LevyCosta]

lgtm

[diegolmello]

Unrelated, but prettier asked me to change.
It won't hurt :)

[diegolmello]

The issue is that we're calling hide without having a splash screen on share extension.
That triggers react-native-bootsplash has not been initialized, similar to zoontek/react-native-bootsplash#264
Recently they wrapped the hide call in a try/catch in the example zoontek/react-native-bootsplash@41e32e8#diff-f92b617bbc90bafc01461177b82175f320578d91293fddfbc810bacb339898edR20

[diegolmello]

@cprice-kgi Merged. Thanks for your contribution :)

[jsalatiel]

Is this the same problem that happens when one tries to share a audio received on whatsapp with someone on rockechat ? After choosing the contact for share, rocketchat gets stuck on a blank window. ( on android , running version 4.20)