[FIX] Disable swipe when room is not joined#3319
Merged
Merged
Conversation
AlexAlexandre
suggested changes
Aug 31, 2021
AlexAlexandre
left a comment
AlexAlexandre
left a comment
Contributor
There was a problem hiding this comment.
The code it's ok, but could you please merge the latest changes from develop into this branch ?
diegolmello
reviewed
Sep 6, 2021
diegolmello
reviewed
Oct 7, 2021
diegolmello
changed the title
diegolmello
approved these changes
Oct 14, 2021
ivnxyz
pushed a commit
to NextiaDev/Rocket.Chat.ReactNative
that referenced
this pull request
May 26, 2023
* [FIX] swipe when the user is joined and not when isn't * Added a new conditional to check if is swipeble or not * Minor tweaks Co-authored-by: Diego Mello <diegolmello@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Remove the button swipe when the main search returns users you aren't talking about yet or rooms you weren't joined.
Issue(s)
How to test or reproduce
Screenshots
Before
Screen.Recording.2021-08-05.at.17.10.21.mov
After
Screen.Recording.2021-08-05.at.17.09.43.mov
Types of changes
Checklist
Further comments