Skip to content

Conversation

@diegolmello
Copy link
Member

@diegolmello diegolmello commented Jul 30, 2021

Proposed changes

Share extension stopped working on iOS after #3245.
On #2845 we started using fewer native modules on share extension, so we could save some memory.
In order for the share extension to work on React Native 0.64.2, I unified that again, so all pods are linked to ShareRocketChatRN once more.
A best approach for removing these calls from the share extension would be to get rid of require cycle, which is the root cause of this issue.

Issue(s)

How to test or reproduce

  • Share extension should work on iOS
    • Share media from Photos to Rocket.Chat
  • Push notification data privacy should work on iOS

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@diegolmello diegolmello changed the title [WIP] [FIX] Share extension not working on iOS [FIX] Share extension not working on iOS Aug 2, 2021
@diegolmello diegolmello merged commit 8e3b79e into develop Aug 20, 2021
@diegolmello diegolmello deleted the fix.share-extension-ios-pods branch August 20, 2021 19:55
@ankar84
Copy link
Contributor

ankar84 commented Sep 28, 2021

@diegolmello hey!
Sharing foto to RCRN app 4.19.0 doesn't work on iPhone 8 on iOS15 - white screen.

@diegolmello
Copy link
Member Author

@ankar84 Can you create a new issue?

@ankar84
Copy link
Contributor

ankar84 commented Sep 29, 2021

@ankar84 Can you create a new issue?

Hm, strange.
Start making new issue and get that error on out whitelabel 4.19.0 app https://share.icloud.com/photos/0buE0sye34e0SNfXNjE6vSj4A
Then test it with 4.20 experimental app and all works perfect.

So, either fix in 4.20 or we broke something in our 4.19 app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants