[FIX] Share extension not working on iOS #3310
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Share extension stopped working on iOS after #3245.
On #2845 we started using fewer native modules on share extension, so we could save some memory.
In order for the share extension to work on React Native 0.64.2, I unified that again, so all pods are linked to ShareRocketChatRN once more.
A best approach for removing these calls from the share extension would be to get rid of require cycle, which is the root cause of this issue.
Issue(s)
How to test or reproduce
Screenshots
Types of changes
Checklist
Further comments