Skip to content

[FIX] Omnichannel custom fields are not rendered properly #3295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
diegolmello merged 9 commits into from
Aug 23, 2021
Merged

[FIX] Omnichannel custom fields are not rendered properly #3295

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
9ebe519
[FIX] Permissions to edit livechat
reinaldonetof Jul 22, 2021
1e70f49
[FIX] Custom fields labels and values
reinaldonetof Jul 24, 2021
c82a223
refactor field
reinaldonetof Jul 26, 2021
3d9575c
Added the permission to edit livechat room custom fields
reinaldonetof Jul 26, 2021
41b6781
Merge branch 'fix.permissions-omnichannel-edit' into fix.omnichannel-…
reinaldonetof Jul 26, 2021
60bdef3
Merge branch 'develop' into fix.omnichannel-custom-fields
reinaldonetof Aug 2, 2021
bd98e14
Fix the inputs.focus()
reinaldonetof Aug 15, 2021
1135fc2
Merge branch 'develop' into fix.omnichannel-custom-fields
LevyCosta Aug 17, 2021
120a344
Merge branch 'develop' into fix.omnichannel-custom-fields
diegolmello Aug 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions app/views/LivechatEditView.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,12 +55,12 @@ const LivechatEditView = ({
const visitorCustomFields = result.customFields
.filter(field => field.visibility !== 'hidden' && field.scope === 'visitor')
.map(field => ({ [field._id]: (visitor.livechatData && visitor.livechatData[field._id]) || '' }))
.reduce((ret, field) => ({ [field]: field, ...ret }));
.reduce((ret, field) => ({ ...field, ...ret }));

const livechatCustomFields = result.customFields
.filter(field => field.visibility !== 'hidden' && field.scope === 'room')
.map(field => ({ [field._id]: (livechat.livechatData && livechat.livechatData[field._id]) || '' }))
.reduce((ret, field) => ({ [field]: field, ...ret }));
.reduce((ret, field) => ({ ...field, ...ret }));

return setCustomFields({ visitor: visitorCustomFields, livechat: livechatCustomFields });
}
Expand Down Expand Up @@ -188,7 +188,7 @@ const LivechatEditView = ({
onSubmitEditing={() => {
const keys = Object.keys(customFields?.visitor || {});
if (keys.length > 0) {
const key = keys.pop();
const key = keys[0];
inputs[key].focus();
} else {
inputs.topic.focus();
Expand All @@ -205,7 +205,7 @@ const LivechatEditView = ({
onChangeText={text => onChangeText(key, text)}
onSubmitEditing={() => {
if (array.length - 1 > index) {
return inputs[array[index + 1]].focus();
return inputs[array[index + 1][0]].focus();
}
inputs.topic.focus();
}}
Expand Down