Skip to content

Fix single-server sending messeages when calling app back via notifications#3145

Merged
diegolmello merged 1 commit into
RocketChat:single-serverfrom
Zeromax:fix/single-server-notification
May 18, 2021
Merged

Fix single-server sending messeages when calling app back via notifications#3145
diegolmello merged 1 commit into
RocketChat:single-serverfrom
Zeromax:fix/single-server-notification

Conversation

@Zeromax

@Zeromax Zeromax commented May 18, 2021

Copy link
Copy Markdown
Contributor

This should fix the Issue described in #3136

Proposed changes

In order while researching the problem from #3136 I found out that the launch mode on master was set different. Setting the launch mode to singleTask as on master, everything works like expected

Tested on Android 11 Pixel 4 and Samsung Galaxy A52

Issue(s)

How to test or reproduce

  1. create a Apk from this branch
  2. Install it
  3. login as a user A
  4. check that notifications are working
  5. move Rocket chat into background
  6. send a message from an other user B
  7. open rocket chat with clicking on the notification
  8. send a message: Sending runs smooth withour error
  9. Sending messages from other channels also works

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

…ations see RocketChat#3136

- set same android launch mode `singleTask` as on master

@diegolmello diegolmello left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@diegolmello diegolmello merged commit cfef04c into RocketChat:single-server May 18, 2021
@diegolmello

Copy link
Copy Markdown
Member

@Zeromax Thanks for your contribution :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants