Skip to content

[IMPROVEMENT] Allow discussions to be edited #3137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
diegolmello merged 4 commits into from
May 27, 2021
Merged

[IMPROVEMENT] Allow discussions to be edited #3137

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9c4223d
Refactored the filter to work the edit for channel and discussion
reinaldonetof May 13, 2021
bc07d2d
Removed the filter which type of room can be edit
reinaldonetof May 14, 2021
a6b85d9
Merge branch 'develop' into fix.info-edit-discussion
diegolmello May 27, 2021
aabc85e
Fix tests
diegolmello May 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/views/RoomInfoView/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@ class RoomInfoView extends React.Component {
}

const permissions = await RocketChat.hasPermission([editRoomPermission], room.rid);
if (permissions[0] && !room.prid) {
if (permissions[0]) {
Comment thread
diegolmello marked this conversation as resolved.
this.setState({ showEdit: true }, () => this.setHeader());
}
}
Expand Down