Skip to content

[FIX] App making calls to DDP after socket was killed by OS #3062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
diegolmello merged 3 commits into from
May 6, 2021
Merged

[FIX] App making calls to DDP after socket was killed by OS #3062

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
03fe0d0
Make sure methodCall isn't undefined
diegolmello Apr 14, 2021
3199a89
Merge branch 'develop' into fix.method-call-state
gerzonc May 3, 2021
7f722c0
Merge branch 'develop' into fix.method-call-state
diegolmello May 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/lib/rocketchat.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1136,7 +1136,7 @@ const RocketChat = {
methodCall(...args) {
return new Promise(async(resolve, reject) => {
try {
const result = await this.sdk.methodCall(...args, this.code || '');
const result = await this.sdk?.methodCall(...args, this.code || '');
return resolve(result);
} catch (e) {
if (e.error && (e.error === 'totp-required' || e.error === 'totp-invalid')) {
Expand Down