Skip to content

[FIX] Cannot read property 'some' of undefined on hasPermission #2966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
diegolmello merged 2 commits into from
Mar 5, 2021
Merged

[FIX] Cannot read property 'some' of undefined on hasPermission #2966

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7d0f80c
[FIX] Cannot read property 'some' of undefined on hasPermission
kresnaputra Mar 5, 2021
04d8ee0
Merge branch 'develop' into fix.cannot.read.property.some.of.undefine…
diegolmello Mar 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/lib/rocketchat.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1192,7 +1192,7 @@ const RocketChat = {
// get user roles on the server from redux
const userRoles = (shareUser?.roles || loginUser?.roles) || [];
const mergedRoles = [...new Set([...roomRoles, ...userRoles])];
return permissions.map(permission => permission.some(r => mergedRoles.includes(r) ?? false));
return permissions.map(permission => permission?.some(r => mergedRoles.includes(r) ?? false));
} catch (e) {
log(e);
}
Expand Down