Skip to content

[TESTS] Add E2E tests to draft message #2960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
diegolmello merged 4 commits into from
Mar 18, 2021
Merged

[TESTS] Add E2E tests to draft message #2960

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6bd26d0
[E2E TEST] Draft message
kresnaputra Mar 4, 2021
722be98
Merge branch 'develop' into e2e.test.for.draft.message
diegolmello Mar 9, 2021
da6a77b
Fix tests
diegolmello Mar 9, 2021
b136717
Merge branch 'develop' into e2e.test.for.draft.message
diegolmello Mar 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 20 additions & 2 deletions e2e/tests/room/02-room.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@ async function navigateToRoom(roomName) {
await waitFor(element(by.id('room-view'))).toBeVisible().withTimeout(5000);
}

const mainRoom = data.groups.private.name;

@diegolmello diegolmello Mar 9, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary changes.

describe('Room screen', () => {
const mainRoom = data.groups.private.name;

before(async() => {
await navigateToRoom(mainRoom);
Expand Down Expand Up @@ -126,6 +126,17 @@ describe('Room screen', () => {
await expect(element(by.id('messagebox-input'))).toHaveText('#general ');
await element(by.id('messagebox-input')).clearText();
});

it('should draft message', async () => {
await element(by.id('messagebox-input')).atIndex(0).tap();
await element(by.id('messagebox-input')).atIndex(0).typeText(`${ data.random }draft`);
await tapBack();
await element(by.id(`rooms-list-view-item-${ mainRoom }`)).tap();
await expect(element(by.id('messagebox-input'))).toHaveText(`${ data.random }draft`);

@diegolmello diegolmello Mar 9, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should test if the room has rendered before testing messagebox content.

await element(by.id('messagebox-input')).clearText();

@diegolmello diegolmello Mar 9, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should test if draft was removed after messagebox is cleared.

});


});

describe('Message', async() => {
Expand Down Expand Up @@ -280,11 +291,18 @@ describe('Room screen', () => {
await waitFor(element(by.id('room-view'))).toBeVisible().withTimeout(5000);
await waitFor(element(by.id(`room-view-title-${ thread }`))).toExist().withTimeout(5000);
await expect(element(by.id(`room-view-title-${ thread }`))).toExist();
});

it('should draft thread message', async () => {
await element(by.id('messagebox-input')).atIndex(0).tap();
await element(by.id('messagebox-input')).atIndex(0).typeText(`${ thread }draft`);
await tapBack();
await element(by.id(`message-thread-button-${ thread }`)).tap();
await expect(element(by.id('messagebox-input')).atIndex(0)).toHaveText(`${ thread }draft`);
await element(by.id('messagebox-input')).atIndex(0).clearText();
});

it('should toggle follow thread', async() => {
await element(by.id(`message-thread-button-${ thread }`)).tap();
await waitFor(element(by.id('room-view'))).toBeVisible().withTimeout(5000);
await waitFor(element(by.id(`room-view-title-${ thread }`))).toExist().withTimeout(5000);
await expect(element(by.id(`room-view-title-${ thread }`))).toExist();
Expand Down