Skip to content

Conversation

@diegolmello
Copy link
Member

Proposed changes

  • Fixed parent title on thread header breaking lines
  • When unread on top is set, channels wouldn't leave unread group in some cases
  • Fixed thread badge color not being updated on the message's thread button

Issue(s)

Closes #2519

How to test or reproduce

Fixed parent title on thread header breaking lines

  • Create a thread on a room with a long name (or a discussion from a long message)
  • Subtitle shouldn't break lines

When unread on top is set, channels wouldn't leave unread group in some cases

  • Enable Unread on top
  • Mark a channel as unread
  • Mark it as read
  • Channel should leave Unread group

Fixed thread badge color not being updated on the message's thread button

  • Focus a room with a thread you're following
  • Send a message from a different user on a thread you're following
  • Thread badge color should update
  • Enter in the thread
  • When you leave it, the badge color should update

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

Copy link
Contributor

@djorkaeffalexandre djorkaeffalexandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@diegolmello diegolmello merged commit 8cac766 into develop Nov 12, 2020
@diegolmello diegolmello deleted the fix.new-threads branch November 12, 2020 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rocket.chat mobile application does not mark channels as read

3 participants