Skip to content

[CHORE] Update run-ios and run-android scripts #2450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
diegolmello merged 2 commits into from
Sep 11, 2020
Merged

[CHORE] Update run-ios and run-android scripts #2450

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8611001
[CHORE] Update run-ios and run-android scripts
diegolmello Sep 2, 2020
c47a7a9
Merge branch 'develop' into fix.run-scripts
diegolmello Sep 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,13 @@ yarn

Run the app:
```sh
npx react-native run-ios
yarn ios
```

or

```sh
npx react-native run-android
yarn android
```

At this point, the app should be running on the simulator or on your device!
Expand Down
5 changes: 2 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,15 +8,14 @@
"test-update": "jest --updateSnapshot",
"lint": "eslint .",
"ci": "npm run precommit && codecov",
"ios": "react-native run-ios",
"ios": "npx react-native run-ios",
"android": "npx react-native run-android --variant=playDebug",
"log-android": "react-native log-android",
"android": "react-native run-android",
"snyk-protect": "snyk protect",
"precommit": "eslint . && jest",
"generate-source-maps-ios": "react-native bundle --platform ios --dev false --entry-file index.js --bundle-output ios-release.bundle --sourcemap-output ios-release.bundle.map",
"generate-source-maps-android": "bugsnag-sourcemaps",
"postinstall": "patch-package && jetify",
"play": "npx react-native run-android --variant=playDebug",
"foss": "npx react-native run-android --variant=fossDebug"
},
"husky": {
Expand Down