Skip to content

[IMPROVEMENT] Disable HTTP for production on Android #2357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
diegolmello merged 6 commits into from
Sep 2, 2020
Merged

[IMPROVEMENT] Disable HTTP for production on Android #2357

Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9076844
Only enable HTTP and user CAs on debug builds and
grahamsmith Jul 30, 2020
12a4e40
Allow User CAs in prod
grahamsmith Jul 30, 2020
02d98fd
Merge branch 'develop' into android-https
diegolmello Aug 27, 2020
f944aab
Merge branch 'develop' into android-https
diegolmello Sep 2, 2020
e97af32
Add config on debug
diegolmello Sep 2, 2020
2b3f42a
Add lint
diegolmello Sep 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions android/app/src/main/res/xml/network_security_config.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,18 @@
<?xml version="1.0" encoding="utf-8"?>
<network-security-config>
<base-config cleartextTrafficPermitted="true">
<network-security-config xmlns:tools="http://schemas.android.com/tools">
<base-config cleartextTrafficPermitted="false">
<trust-anchors>
<certificates src="system" />
<certificates src="user" />
<certificates src="user"
tools:ignore="AcceptsUserCertificates" />

@diegolmello diegolmello Sep 2, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@grahamsmith Why do we need this?

@grahamsmith grahamsmith Sep 2, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because Android Studio's linter highlights this as a security risk and so the ignore tells it not to worry.

@diegolmello diegolmello Sep 2, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, thanks!

</trust-anchors>
</base-config>
<debug-overrides>

@diegolmello diegolmello Aug 27, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like it's not working.
You can try running your app on your device with: npx react-native run-android --variant=playDebug
You're going to get this screen:

That's because the JS bundle is sent to the device via port 8081 and it needs cleartextTrafficPermitted="true".
Apparently, <debug-overrides> isn't really doing anything.
If I got it right, <debug-overrides> can't contain a <base-config>: https://developer.android.com/training/articles/security-config#debug-overrides

@grahamsmith grahamsmith Aug 28, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll take a look - I forgot about how RN debugging works as I tried with a production build. 👍

<base-config cleartextTrafficPermitted="true" >
<trust-anchors>
<certificates src="user" />
<certificates src="system" />
</trust-anchors>
</base-config>
</debug-overrides>
</network-security-config>