Run tests in docker #2250
Closed
Run tests in docker #2250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fishbowler
commented
Jul 8, 2020
diegolmello
requested changes
Jul 8, 2020
| const value = random(20); | ||
| const data = { | ||
| server: 'https://ilarion.rocket.chat', | ||
| server: 'http://127.0.0.1:3000', |
Member
There was a problem hiding this comment.
This change makes tests to fail on CircleCI.
Can you run the docker on CI tests as well?
Fishbowler
force-pushed
the
test_in_docker
branch
8 times, most recently
from
da037f6 to
1c25c05
Compare
Fishbowler
force-pushed
the
test_in_docker
branch
from
1c25c05 to
8450085
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/ReactNative
Now runs tests in Docker rather than against an existing Rocket.Chat server, using the existing Docker Compose file for Rocket.Chat plus some overrides, and populated using Mongo's inbuilt init scripts for their docker image.
Also includes: