Skip to content

[REGRESSION] Audio Recording #2240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
diegolmello merged 2 commits into from
Jul 3, 2020
Merged

[REGRESSION] Audio Recording #2240

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
da5b654
[REGRESSION] Audio Recording
djorkaeffalexandre Jul 3, 2020
de4deb9
Merge branch 'develop' into fix.audio-recording
diegolmello Jul 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions app/containers/MessageBox/Recording.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,9 +94,6 @@ export default class extends React.PureComponent {
if (!didSucceed) {
return onFinish && onFinish(didSucceed);
}
if (isAndroid) {
filePath = filePath.startsWith('file://') ? filePath : `file://${ filePath }`;
}
const fileInfo = {
name: this.name,
mime: 'audio/aac',
Expand All @@ -111,8 +108,9 @@ export default class extends React.PureComponent {
finishAudioMessage = async() => {
try {
this.recording = false;
const filePath = await AudioRecorder.stopRecording();
let filePath = await AudioRecorder.stopRecording();
if (isAndroid) {
filePath = filePath.startsWith('file://') ? filePath : `file://${ filePath }`;
const data = await FileSystem.getInfoAsync(decodeURIComponent(filePath), { size: true });
this.finishRecording(true, filePath, data.size);
}
Expand Down