-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[CHORE] Create DimensionsContext #2098
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
diegolmello
merged 12 commits into
RocketChat:develop
from
EzequielDeOliveira:DimensionsMiddleware
Jun 17, 2020
Merged
Changes from 6 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
adfd800
Create middleware and action and reduce
EzequielDeOliveira acefdd9
Apply middleware
EzequielDeOliveira a43385b
Save dimensions in store
EzequielDeOliveira 89bc164
Change lib for props
EzequielDeOliveira 4f2f206
react-native-responsive-ui removed
EzequielDeOliveira 95dcbcc
Merge branch 'develop' into DimensionsMiddleware
diegolmello a431806
Using dimensions middleware instead of directly Dimensions.get
EzequielDeOliveira 94c115a
Removing setTimeout in the Dimensions middleware
EzequielDeOliveira 84774de
Merge branch 'develop' into DimensionsMiddleware
diegolmello e0bd6bc
useDimensions and useOrientation
diegolmello cb105fe
DimensionsContext
diegolmello 3ac6c2f
ActionSheet
diegolmello File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| import { DIMENSIONS } from './actionsTypes'; | ||
|
|
||
| export function dimensionsWindow(window) { | ||
| return { | ||
| type: DIMENSIONS.WINDOW, | ||
| window | ||
| }; | ||
| } | ||
|
|
||
| export function dimensionsScreen(screen) { | ||
| return { | ||
| type: DIMENSIONS.SCREEN, | ||
| screen | ||
| }; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| import { Dimensions } from 'react-native'; | ||
|
|
||
| import { dimensionsWindow, dimensionsScreen } from '../actions/dimensions'; | ||
|
|
||
| export default () => createStore => (...args) => { | ||
| const store = createStore(...args); | ||
|
|
||
| const handleDimensionsChange = (nextDimensionState) => { | ||
|
EzequielDeOliveira marked this conversation as resolved.
Outdated
|
||
| if (nextDimensionState) { | ||
| if (nextDimensionState.window) { | ||
| store.dispatch(dimensionsWindow(nextDimensionState.window)); | ||
| } | ||
| if (nextDimensionState.screen) { | ||
|
EzequielDeOliveira marked this conversation as resolved.
Outdated
|
||
| store.dispatch(dimensionsScreen(nextDimensionState.screen)); | ||
| } | ||
| } | ||
| }; | ||
|
|
||
| Dimensions.addEventListener('change', handleDimensionsChange); | ||
|
|
||
| setTimeout(() => handleDimensionsChange({ ...Dimensions.get('window'), ...Dimensions.get('screen') })); | ||
| return store; | ||
| }; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| import { DIMENSIONS } from '../actions/actionsTypes'; | ||
|
|
||
| const initialState = { | ||
|
EzequielDeOliveira marked this conversation as resolved.
Outdated
|
||
| window: {}, | ||
| screen: {} | ||
| }; | ||
|
|
||
| export default function(state = initialState, action) { | ||
| switch (action.type) { | ||
| case DIMENSIONS.WINDOW: | ||
| return { | ||
| ...state, | ||
| window: action.window | ||
| }; | ||
| case DIMENSIONS.SCREEN: | ||
| return { | ||
| ...state, | ||
| screen: action.screen | ||
| }; | ||
| default: | ||
| return state; | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.