Fixed threadview error #1971
Closed
Fixed threadview error #1971
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegolmello
requested changes
Apr 1, 2020
Member
|
@Prateek93a It doesn't seem to fix the issue. |
Contributor
Author
|
@diegolmello Yes Sir, the issue is not solved properly. Actually on rooms, which we have joined, the thread view does not show error now and shows all the threads and updates under changes properly, but on rooms we have not joined the thread view always shows empty screen even if there are threads in the room as the subscription record for that room is not found in the local db. |
Member
|
It's going to be fixed by #1997 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/ReactNative
Closes #1970
As the Gif shows, the error is fixed. It was similar to #1444 .