-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[FIX] Send auth for Avatar requests only if necessary #1914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
djorkaeffalexandre
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know why, but I tried it with a server v3.0.0-develop and this setting always returned undefined, try to test it and make sure it's right before submit a ready for review PR.
Thanks.
app/containers/Avatar.js
Outdated
|
|
||
| let avatarAuthURLFragment = ''; | ||
| if (userId && token) { | ||
| if (userId && token && !Accounts_AvatarBlockUnauthenticatedAccess) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The right behavior is exactly the opposite, when Accounts_AvatarBlockUnauthenticatedAccess is true we need to add the avatarAuthURLFragment, if it's false we don't need to add this.
|
@devyaniChoubey I reported the original issue, and love that you've had a shot at fixing it. I don't begin to understand the message that the CI is pumping out. Any ideas? |
…eactNative into devyaniChoubey:feature38
|
Refer to #2517. |
@RocketChat/ReactNative
Closes #1871
Depends on RocketChat/Rocket.Chat#18316