Skip to content

[NEW] Image Viewer #1479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
diegolmello merged 27 commits into from
Dec 18, 2019
Merged

[NEW] Image Viewer #1479

Show file tree
Hide file tree
Changes from 13 commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
56793d2
Stash
djorkaeffalexandre Dec 17, 2019
0a2c4ec
Add pods
djorkaeffalexandre Dec 17, 2019
140373a
Loading
djorkaeffalexandre Dec 17, 2019
14b8b03
Remove File Modal
djorkaeffalexandre Dec 17, 2019
283f78b
Merge develop
djorkaeffalexandre Dec 17, 2019
44e70c4
Improve UX
djorkaeffalexandre Dec 17, 2019
048af47
Fix save
djorkaeffalexandre Dec 17, 2019
1ce0702
Fix shared id
djorkaeffalexandre Dec 17, 2019
c9499a0
Encode uri
djorkaeffalexandre Dec 17, 2019
7b0d512
Use animated fast image
djorkaeffalexandre Dec 17, 2019
905d8d2
Fixes
djorkaeffalexandre Dec 17, 2019
1916996
Pod install
djorkaeffalexandre Dec 17, 2019
82fd2a6
Fix android permission
djorkaeffalexandre Dec 17, 2019
b677590
Merge branch 'develop' of https://github.com/RocketChat/Rocket.Chat.R…
djorkaeffalexandre Dec 18, 2019
b2ef18f
Fixes
djorkaeffalexandre Dec 18, 2019
5c557b6
Fix formatAttachmentUrl
djorkaeffalexandre Dec 18, 2019
1c8ec34
I18n
djorkaeffalexandre Dec 18, 2019
e101698
Save to Album Rocket.Chat & Tablet AttachmentView
djorkaeffalexandre Dec 18, 2019
afea195
Fix load video
djorkaeffalexandre Dec 18, 2019
a9d1fd0
Add image progress
djorkaeffalexandre Dec 18, 2019
60d37c9
Files on tablet
djorkaeffalexandre Dec 18, 2019
2121f89
Use Progress.Pie on Image
diegolmello Dec 18, 2019
7443921
Hash downloaded file
diegolmello Dec 18, 2019
89b8cc5
Use image extension from server
djorkaeffalexandre Dec 18, 2019
265d991
Remove console
djorkaeffalexandre Dec 18, 2019
41fb0aa
Remove unused props
djorkaeffalexandre Dec 18, 2019
57c1656
Merge branch 'develop' into new.image-viewer
diegolmello Dec 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
132 changes: 0 additions & 132 deletions app/containers/FileModal.js
View file
Open in desktop

This file was deleted.

10 changes: 10 additions & 0 deletions app/containers/HeaderButton.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,12 @@ export const MoreButton = React.memo(({ onPress, testID }) => (
</CustomHeaderButtons>
));

export const SaveButton = React.memo(({ onPress, testID }) => (
<CustomHeaderButtons>
<Item title='save' iconName='Download' onPress={onPress} testID={testID} />
</CustomHeaderButtons>
));

export const LegalButton = React.memo(({ navigation, testID }) => (
<MoreButton onPress={() => navigation.navigate('LegalView')} testID={testID} />
));
Expand All @@ -80,6 +86,10 @@ MoreButton.propTypes = {
onPress: PropTypes.func.isRequired,
testID: PropTypes.string.isRequired
};
SaveButton.propTypes = {
onPress: PropTypes.func.isRequired,
testID: PropTypes.string.isRequired
};
LegalButton.propTypes = {
navigation: PropTypes.object.isRequired,
testID: PropTypes.string.isRequired
Expand Down
4 changes: 4 additions & 0 deletions app/i18n/locales/en.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ export default {
'error-duplicate-channel-name': 'A channel with name {{channel_name}} exists',
'error-email-domain-blacklisted': 'The email domain is blacklisted',
'error-email-send-failed': 'Error trying to send email: {{message}}',
'error-save-image': 'Error in saving image',
Comment thread
djorkaeffalexandre marked this conversation as resolved.
Outdated
'error-field-unavailable': '{{field}} is already in use :(',
'error-file-too-large': 'File is too large',
'error-importer-not-defined': 'The importer was not defined correctly, it is missing the Import class.',
Expand Down Expand Up @@ -338,6 +339,7 @@ export default {
saving_preferences: 'saving preferences',
saving_profile: 'saving profile',
saving_settings: 'saving settings',
saved_to_gallery: 'Saved to gallery',
Search_Messages: 'Search Messages',
Search: 'Search',
Search_by: 'Search by',
Expand Down Expand Up @@ -434,6 +436,8 @@ export default {
Welcome_to_RocketChat: 'Welcome to Rocket.Chat',
Whats_your_2fa: 'What\'s your 2FA code?',
Without_Servers: 'Without Servers',
Write_External_Permission_Message: 'Rocket Chat needs access to your gallery so you can save images.',
Write_External_Permission: 'Gallery Permission',
Yes_action_it: 'Yes, {{action}} it!',
Yesterday: 'Yesterday',
You_are_in_preview_mode: 'You are in preview mode',
Expand Down
2 changes: 2 additions & 0 deletions app/i18n/locales/pt-BR.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -401,6 +401,8 @@ export default {
You: 'Você',
You_need_to_access_at_least_one_RocketChat_server_to_share_something: 'Você precisa acessar ao menos um servidor Rocket.Chat para compartilhar.',
You_will_not_be_able_to_recover_this_message: 'Você não será capaz de recuperar essa mensagem!',
Write_External_Permission_Message: 'Rocket Chat precisa de acesso a sua galeria para salvar imagens.',
Comment thread
djorkaeffalexandre marked this conversation as resolved.
Outdated
Write_External_Permission: 'Acesso a Galeria',
Comment thread
djorkaeffalexandre marked this conversation as resolved.
Outdated
Crash_report_disclaimer: 'Nós não rastreamos o conteúdo das suas conversas. O relatório de erros apenas contém informações relevantes para identificarmos problemas e corrigí-los.',
Type_message: 'Digitar mensagem',
Room_search: 'Busca de sala',
Expand Down
10 changes: 10 additions & 0 deletions app/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,9 +258,19 @@ const NewMessageStack = createStackNavigator({
cardStyle
});

const AttachmentStack = createStackNavigator({
AttachmentView: {
getScreen: () => require('./views/AttachmentView').default
}
}, {
defaultNavigationOptions: defaultHeader,
cardStyle
});

const InsideStackModal = createStackNavigator({
Main: ChatsDrawer,
NewMessageStack,
AttachmentStack,
JitsiMeetView: {
getScreen: () => require('./views/JitsiMeetView').default
}
Expand Down
Loading