Skip to content

[NEW] Enable Hermes #1446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
diegolmello merged 10 commits into from
Dec 11, 2019
Merged

[NEW] Enable Hermes #1446

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
cfe6b1c
temp
diegolmello Dec 6, 2019
ad4a8fd
emoji parser util
diegolmello Dec 6, 2019
0c66582
Create shortnameToUnicode util
diegolmello Dec 6, 2019
8494b4d
Convert ascii
diegolmello Dec 9, 2019
e42002c
Refactor
diegolmello Dec 9, 2019
9ca1525
Add tests
diegolmello Dec 9, 2019
41f4bb5
Replace huge regex with simpler regex + property check
diegolmello Dec 9, 2019
8c05c42
[NEW] Hermes
diegolmello Dec 9, 2019
a1894b0
assembleRelease instead of bundleRelease
diegolmello Dec 9, 2019
0132b1d
Merge branch 'develop' into new.hermes
diegolmello Dec 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,8 @@ jobs:
npx jetify
cd android
if [[ $KEYSTORE ]]; then
./gradlew bundleRelease
# TODO: enable app bundle again
./gradlew assembleRelease
else
./gradlew assembleDebug
fi
Expand Down
2 changes: 1 addition & 1 deletion android/app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ project.ext.react = [
entryFile: "index.js",
bundleAssetName: "app.bundle",
iconFontNames: [ 'custom.ttf' ],
enableHermes: false, // clean and rebuild if changing
enableHermes: true, // clean and rebuild if changing
]

apply from: "../../node_modules/react-native/react.gradle"
Expand Down
26 changes: 13 additions & 13 deletions android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,16 +55,16 @@ allprojects {
}
}

// subprojects { subproject ->
// afterEvaluate {
// if ((subproject.plugins.hasPlugin('android') || subproject.plugins.hasPlugin('android-library'))) {
// android {
// compileSdkVersion 28
// buildToolsVersion "28.0.3"
// defaultConfig {
// targetSdkVersion 28
// }
// }
// }
// }
// }
subprojects { subproject ->
afterEvaluate {
if ((subproject.plugins.hasPlugin('android') || subproject.plugins.hasPlugin('android-library'))) {
android {
compileSdkVersion 28
buildToolsVersion "28.0.3"
defaultConfig {
targetSdkVersion 28
}
}
}
}
}