Skip to content

[IMPROVEMENT] Tap app and server version to copy to clipboard #1425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
diegolmello merged 12 commits into from
Dec 17, 2019
Merged

[IMPROVEMENT] Tap app and server version to copy to clipboard #1425

Changes from 11 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
1239bdf
initial-commit
Prateek93a Nov 27, 2019
6546f9a
implemented-feature
Prateek93a Nov 27, 2019
1db94fd
updated branch
Prateek93a Nov 27, 2019
6b9967c
fixed import issue
Prateek93a Nov 28, 2019
45a8a9e
alert-changed-to-toast-component
Prateek93a Nov 28, 2019
f0078e5
removed-anonymous-function
Prateek93a Nov 28, 2019
767c320
Merge branch 'develop' into save-to-clipboard
Prateek93a Dec 5, 2019
99ffe5a
removed-lint-errors
Prateek93a Dec 5, 2019
2c7d590
removed-useless-assignment
Prateek93a Dec 8, 2019
c6092af
Merge branch 'develop' of https://github.com/RocketChat/Rocket.Chat.R…
djorkaeffalexandre Dec 11, 2019
2032966
Merge branch 'develop' of https://github.com/RocketChat/Rocket.Chat.R…
djorkaeffalexandre Dec 16, 2019
dfbfb93
Merge branch 'develop' into save-to-clipboard
diegolmello Dec 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 26 additions & 2 deletions app/views/SettingsView/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import React from 'react';
import {
View, Linking, ScrollView, AsyncStorage, SafeAreaView, Switch, Text, Share
View, Linking, ScrollView, AsyncStorage, SafeAreaView, Switch, Text, Share, Clipboard
} from 'react-native';
import PropTypes from 'prop-types';
import { connect } from 'react-redux';
Expand Down Expand Up @@ -31,6 +31,8 @@ import { themedHeader } from '../../utils/navigation';
import SidebarView from '../SidebarView';
import { withSplit } from '../../split';
import Navigation from '../../lib/Navigation';
import { LISTENER } from '../../containers/Toast';
import EventEmitter from '../../utils/events';

const SectionSeparator = React.memo(({ theme }) => (
<View
Expand Down Expand Up @@ -131,6 +133,20 @@ class SettingsView extends React.Component {
Share.share({ message: isAndroid ? PLAY_MARKET_LINK : APP_STORE_LINK });
}

copyServerVersion = () => {
const { server } = this.props;
this.saveToClipboard(server.version);
}

copyAppVersion = () => {
this.saveToClipboard(getReadableVersion);
}

saveToClipboard = async(content) => {
await Clipboard.setString(content);
EventEmitter.emit(LISTENER, { message: I18n.t('Copied_to_clipboard') });
}

changeTheme = () => {
const { navigation } = this.props;
navigation.navigate('ThemeView');
Expand Down Expand Up @@ -267,11 +283,19 @@ class SettingsView extends React.Component {
right={this.renderDisclosure}
theme={theme}
/>

<Separator theme={theme} />
<ListItem title={I18n.t('Version_no', { version: getReadableVersion })} testID='settings-view-version' theme={theme} />
<ListItem
title={I18n.t('Version_no', { version: getReadableVersion })}
onPress={this.copyAppVersion}
testID='settings-view-version'
theme={theme}
/>
<Separator theme={theme} />

<ListItem
title={I18n.t('Server_version', { version: server.version })}
onPress={this.copyServerVersion}
subtitle={`${ server.server.split('//')[1] }`}
testID='settings-view-server-version'
theme={theme}
Expand Down