Skip to content

[FIX] Message actions on Image messages #1205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
BrunoOliveiraDantas wants to merge 5 commits into from
Closed

[FIX] Message actions on Image messages #1205

BrunoOliveiraDantas wants to merge 5 commits into from

Conversation

@BrunoOliveiraDantas
Copy link
Contributor

@BrunoOliveiraDantas BrunoOliveiraDantas commented Sep 18, 2019

@RocketChat/ReactNative

Closes #1193

image
image
image

BrunoOliveiraDantas and others added 3 commits September 17, 2019 17:27
@BrunoOliveiraDantas
Add onLongPress event to thread.
160a632 
Co-authored-by: Vitor Menezes <[email protected]>
Co-authored-by: lucassiqz <[email protected]>
Co-authored-by: Caiocbeleza <[email protected]>
Co-authored-by: CalebeRios <[email protected]>
@LucasSiqz @BrunoOliveiraDantas
Add missing onLongPress call
121317d 
Signed-off-by: Lucas Siqueira <[email protected]>
Co-authored-by: Bruno Dantas <[email protected]>
@LucasSiqz
Merge remote-tracking branch 'upstream/develop' into ReplyImageThread
44014bf
@CLAassistant
Copy link

CLAassistant commented Sep 18, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@djorkaeffalexandre
Copy link
Contributor

djorkaeffalexandre commented Sep 18, 2019

@BrunoOliveiraDantas can you add a gif?

@djorkaeffalexandre djorkaeffalexandre changed the title [FIX] Reply image thread [FIX] Message actions on Image messages Sep 18, 2019
@LucasSiqz
Copy link
Contributor

LucasSiqz commented Sep 19, 2019

@BrunoOliveiraDantas can you add a gif?

Message-actions-image

@djorkaeffalexandre
Copy link
Contributor

djorkaeffalexandre commented Sep 19, 2019

@BrunoOliveiraDantas @LucasSiqz it's falling on ci:
https://circleci.com/gh/RocketChat/Rocket.Chat.ReactNative/11385?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link

@diegolmello
Copy link
Member

diegolmello commented Sep 25, 2019

I'll try using react-native-gesture-handler as the priority onLongPress handler before reviewing this PR.
If that works properly, it would be better than always drilling onLongPress for every button.

@djorkaeffalexandre
Copy link
Contributor

djorkaeffalexandre commented Jun 2, 2020

Was fixed by #2082.
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Cannot reply with thread/quote to message with image only.

5 participants

@BrunoOliveiraDantas @CLAassistant @djorkaeffalexandre @LucasSiqz @diegolmello