[WIP] Custom Status Mobile UI #1176

wreiske · 2019-09-05T07:47:23Z

@RocketChat/ReactNative

This is a work in progress. Any help is greatly appreciated!

Here are some sample images so far:

lgtm-com · 2019-09-05T07:55:55Z

This pull request introduces 1 alert when merging 61de50c into 0ea0dc2 - view on LGTM.com

new alerts:

1 for Unused variable, import, function or class

wreiske · 2019-09-05T08:22:51Z

Things that need to be figured out:

It doesn't look like the 'user-status' events are updating / or there's something needed to redraw the statuses. They aren't changing if you change the status on another client.
Figure out why the status isn't pulling in on the profile page to edit
The status is currently showing as the current user in every channel. Need to figure out how to show the room user's status instead of the current logged in user.

Should I use the header background color here?

Instead of the custom color I picked above? Maybe there's a better color to put there....

lgtm-com · 2019-09-05T08:43:41Z

This pull request introduces 1 alert when merging f90b76f into 0ea0dc2 - view on LGTM.com

new alerts:

1 for Unused variable, import, function or class

djorkaeffalexandre · 2019-09-05T11:17:35Z

app/views/RoomView/index.js

 		return (
 			<SafeAreaView style={styles.container} testID='room-view' forceInset={{ vertical: 'never' }}>
 				<StatusBar />
+				{this.t === 'd' && user && user.statusText ? (


create a function like a renderStatusText() :)

wreiske · 2019-09-09T17:36:22Z

I have a strict deadline that I must hit this week, so it will be later in the week before I will have time to mess with this again. If anyone wants to take a stab at it, go ahead. It'll be Thursday or Friday before I go at it again. Thanks!

Prateek93a · 2020-01-20T14:04:21Z

@wreiske @diegolmello @djorkaeffalexandre Hello, I would like to show my work on this feature. I used all the code that @wreiske had written to implement the above mentioned feature. Most of the work was already done. I added my code to solve the 3 issues mentioned above, added change status modal and added theme support and resolved the conflicts. Also I thought it would be better not to show status text at the top of the room view, so I removed it but it can be added again if needed. The gif is shown below. Does it look fine?

wreiske · 2020-01-20T14:57:28Z

@Prateek93a Thanks for updating and fixing the issues described above. Can you open a pull request to merge into wreiske:custom-status-ui? I will look at the changes and merge them into this PR.

I would rather (IMO) see the status on the room view if it's a direct message, there's room there to have it, so why not show it? People aren't going to click into user's profiles to see their status -- but they will see it if it's in the room header.

Prateek93a · 2020-01-20T17:17:19Z

@wreiske Yes you are right. Now I get it, status should be visible on the room view as well so that people can see it otherwise not everyone will look into the room info to see status. Thanks.
Also,I am a little confused here, how should I raise Pr to merge into wreiske:custom-status-ui? Should I raise Pr in your forked repo?

wreiske · 2020-01-20T17:18:27Z

That would work, yes. I will review it in the next 2 business days and get it merged in. That will update this PR.

Prateek93a · 2020-01-20T17:21:12Z

I tried to do that. First I tried to fork your repo but github gave message that I already had a forked repo of Rocket.Chat.ReactNative.Then I tried to directly raise Pr to your forked repo, but that gave access denied error.

wreiske · 2020-01-20T17:36:53Z

I created a PR. It should automatically update as you push changes to your branch.

wreiske#1

Prateek93a · 2020-01-20T17:52:47Z

Ok Thanks

Status merge

wreiske · 2020-01-25T19:55:50Z

@Prateek93a if you can take a look at why the status modal isn't refreshing the latest status, that'd be great. thanks!

Change status on mobile app.
Change status on desktop
Tap to change status on mobile app to see the original status message in the modal.

Prateek93a · 2020-01-25T19:59:26Z

@wreiske Yes, surely. I will try to fix by tomorrow .

wreiske · 2020-01-25T20:04:08Z

@wreiske Yes, surely. I will try to fix by tomorrow .

Also, the original bugs still exist... The status message does not refresh in the mobile app when changed on desktop. You have to click out of the room and click back in to see the change.

It also looks like this introduced some bugs. When there is no status message, the status bar shouldn't be displayed in a DM.

The status also doesn't refresh in the user profile:

Thanks for all the help!

Prateek93a · 2020-01-25T20:20:08Z

Ok I will look into the bug, and also make the changes that you suggested.

Prateek93a · 2020-01-26T13:25:47Z

@Prateek93a if you can take a look at why the status modal isn't refreshing the latest status, that'd be great. thanks!
* Change status on mobile app.

* Change status on desktop

* Tap to change status on mobile app to see the original status message in the modal.

@wreiske I have fixed the above bug, and also added the code to hide the status text bar when there is no status. Now I am working on the last bug where the room status was not getting updated. Also I tried pushing my commits, but for that I had to pull the changes first. But when I pulled, the code was still having duplicates, and fixed color. I am not sure why this happened. So shall I remove them and then push the commits?

wreiske · 2020-01-26T19:32:44Z

It may be best to fork my repo, edit the custom status ui branch, and then make a pull request back. If you fork my repo on the branch this PR is, it shouldn't have any duplicates. That way you run another PR to my fork, I'll review and test, and then merge it and this PR will update.

Prateek93a · 2020-01-27T12:00:05Z

Actually I tried to do that but since I already have a forked this repo, so I am not able to fork your repo.
I have received the latest commit you made i.e. merge pull request but in that, there was no commit to remove the duplicate code. I think if you push the remove duplicates commit again, then after pulling the changes I shall receive those changes.

Initial commit test proof of concept for user statuses in mobile app

61de50c

wreiske added 2 commits September 5, 2019 04:28

i18n and fixed prop issue + don't show unless we're in a direct message

3bc9199

Fixed editing user status from profile page

f90b76f

wreiske added 2 commits September 5, 2019 04:44

Removed unused variable COLOR_BACKGROUND_NOTIFICATION

ad6990b

Don't show the status view bar unless there is actually a status to show

2d66de9

djorkaeffalexandre reviewed Sep 5, 2019

View reviewed changes

diegolmello added 🎉 feature 🚧 wip labels Sep 17, 2019

diegolmello mentioned this pull request Jan 9, 2020

Set a custom status message #1536

Closed

Prateek93a added 4 commits January 19, 2020 22:21

added-changes-of-wreiske

7acaf7f

fixed-status-text-not-updating-issue

4e8ceaa

implemented-status-text-feature

0a8592c

removed-status-text-from-room-view

0ac53de

added-status-text-to-room-view

c64b3ca

Merge branch 'develop' into custom-status-ui

03bb47c

Prateek93a and others added 3 commits January 20, 2020 23:38

Merge branch 'custom-status-ui' into set-status

673c25f

Removed duplicate code and fixed theme on status bar

03c1498

Merge pull request #2 from wreiske/status-merge

5511c4f

Status merge

djorkaeffalexandre mentioned this pull request Mar 2, 2020

[NEW] Custom Status #1811

Merged

6 tasks

diegolmello closed this Mar 3, 2020

[WIP] Custom Status Mobile UI #1176

[WIP] Custom Status Mobile UI #1176

Uh oh!

Conversation

wreiske commented Sep 5, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lgtm-com bot commented Sep 5, 2019

Uh oh!

wreiske commented Sep 5, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lgtm-com bot commented Sep 5, 2019

Uh oh!

djorkaeffalexandre Sep 5, 2019

Choose a reason for hiding this comment

Uh oh!

wreiske commented Sep 9, 2019

Uh oh!

Prateek93a commented Jan 20, 2020

Uh oh!

wreiske commented Jan 20, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Prateek93a commented Jan 20, 2020

Uh oh!

wreiske commented Jan 20, 2020

Uh oh!

Prateek93a commented Jan 20, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wreiske commented Jan 20, 2020

Uh oh!

Prateek93a commented Jan 20, 2020

Uh oh!

wreiske commented Jan 25, 2020

Uh oh!

Prateek93a commented Jan 25, 2020

Uh oh!

wreiske commented Jan 25, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Prateek93a commented Jan 25, 2020

Uh oh!

Prateek93a commented Jan 26, 2020

Uh oh!

wreiske commented Jan 26, 2020

Uh oh!

Prateek93a commented Jan 27, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

wreiske commented Sep 5, 2019 •

edited

Loading

wreiske commented Sep 5, 2019 •

edited

Loading

wreiske commented Jan 20, 2020 •

edited

Loading

Prateek93a commented Jan 20, 2020 •

edited

Loading

wreiske commented Jan 25, 2020 •

edited

Loading