-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[FIX] Share Extension issues #1064
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 20 commits
Commits
Show all changes
61 commits
Select commit
Hold shift + click to select a range
6243b68
Try to fix performance
djorkaeffalexandre b043f9a
Add slice to fix crash memory
djorkaeffalexandre df66504
Remove sort and group by type
djorkaeffalexandre 2346f57
Remove slice
djorkaeffalexandre 796dea4
Fix memory on search
djorkaeffalexandre 92ed265
Update code
djorkaeffalexandre 68a7e24
Minor fixes
djorkaeffalexandre f2f83d8
Add border bottom to flatlist content
djorkaeffalexandre 818dfb4
Add cancel button to search
djorkaeffalexandre 59d90d0
Remove unnecessary socket
djorkaeffalexandre c943f88
Add loading while get subscriptions
djorkaeffalexandre fc171b6
Fix can upload file on Share Extension
djorkaeffalexandre 6174761
Allow change server on file not allowed
djorkaeffalexandre 4913d9b
Fix loading if error on upload media
djorkaeffalexandre 356e7be
Remove debounce
djorkaeffalexandre 95b7395
Fix infinity loading
djorkaeffalexandre 6d3f6b6
Fix cancel button translate
djorkaeffalexandre 662225d
Fix error on get userId - Share Extension
djorkaeffalexandre 377edac
Fix share message
djorkaeffalexandre a88b811
Improve share extension init
djorkaeffalexandre 7de1e90
Update code
djorkaeffalexandre 22a07aa
Fix login sdk
djorkaeffalexandre 5c8c3d8
Add search on header
djorkaeffalexandre 0c34978
Fix padding on notch devices
djorkaeffalexandre c9b467a
Fix search after click on item
djorkaeffalexandre 125acfd
Improve clear search
djorkaeffalexandre 71092d6
Update schemaVersion
djorkaeffalexandre fb4a4b9
Refactor header share list
djorkaeffalexandre 5688a8f
Improve setSearch
djorkaeffalexandre 9070afa
Remove react-native-iphone-x-helper
djorkaeffalexandre b50721f
Improve search
djorkaeffalexandre 9d6b008
Adjust some styles
djorkaeffalexandre 9196270
Merge branch 'develop' into fix.share-extension-performance
diegolmello a7faf45
Change deployment target & bump version & change device compatibility
djorkaeffalexandre c0f3aee
Merge branch 'fix.share-extension-performance' of https://github.com/…
djorkaeffalexandre 08d50be
Upgrade rn-extension-share
djorkaeffalexandre 027c3b4
If there's no current token, show OutsideStack
diegolmello 479020e
Missing translation
diegolmello ee7b304
Change from "Select channels" to "Send to..."
diegolmello 46d0ef6
Enabled `canSend` as default
diegolmello 4872bfa
Increase server icon size to align server label with channels labels
diegolmello 15ce435
Android search header as React.memo
diegolmello f402ab5
Cancel search on Android back press
diegolmello aaa6576
Refactor
diegolmello a67307e
StatusBar
diegolmello 0d520c4
Fix server change
diegolmello 791ead2
Migrate Share Extension methods to external classes because android r…
djorkaeffalexandre 04fcd0c
Merge
djorkaeffalexandre 20c1918
Fix send file message
djorkaeffalexandre a91b191
Improve code
djorkaeffalexandre d0d0b81
Fix multiple logins android
djorkaeffalexandre 6b7bc65
Change params to sendMessage
djorkaeffalexandre 9e06611
Change params to sendFileMessage
djorkaeffalexandre 5cba5d9
Fix problem on sendFileMessage
djorkaeffalexandre 294a139
Fix file size
djorkaeffalexandre 616dc7d
Change react-native-realm-path to podfile
djorkaeffalexandre c159f27
Change rn-extensions-share to Podfile
djorkaeffalexandre b018644
Upgrade rn-extensions-share
djorkaeffalexandre 57c94a2
Fix error on canUploadFile
djorkaeffalexandre 54c7afa
Improve code
djorkaeffalexandre 583d18c
Fix error when you try to upload a invalid file
djorkaeffalexandre File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| import React, { useState } from 'react'; | ||
| import PropTypes from 'prop-types'; | ||
| import { Keyboard, LayoutAnimation } from 'react-native'; | ||
|
|
||
| import SearchBox from '../../containers/SearchBox'; | ||
| import { isIOS } from '../../utils/deviceInfo'; | ||
|
|
||
| const SearchBar = React.memo(({ onChangeSearchText }) => { | ||
| const [text, setText] = useState(''); | ||
| const [hasCancel, setHasCancel] = useState(false); | ||
|
|
||
| const onChangeText = (searchText) => { | ||
| onChangeSearchText(searchText); | ||
| setText(searchText); | ||
| }; | ||
|
|
||
| const onCancelPress = () => { | ||
| Keyboard.dismiss(); | ||
| onChangeText(''); | ||
| setHasCancel(false); | ||
| }; | ||
|
|
||
| const onFocus = () => { | ||
| setHasCancel(true); | ||
| LayoutAnimation.easeInEaseOut(); | ||
|
djorkaeffalexandre marked this conversation as resolved.
Outdated
|
||
| }; | ||
|
|
||
| if (isIOS) { | ||
| return ( | ||
| <SearchBox | ||
| value={text} | ||
| hasCancel={hasCancel} | ||
| onFocus={onFocus} | ||
| onCancelPress={onCancelPress} | ||
| onChangeText={onChangeText} | ||
| testID='rooms-list-view-search' | ||
| key='rooms-list-view-search' | ||
| /> | ||
| ); | ||
| } | ||
| return null; | ||
| }); | ||
|
|
||
| SearchBar.propTypes = { | ||
| onChangeSearchText: PropTypes.func | ||
| }; | ||
|
|
||
| export default SearchBar; | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.