Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic DDP #2

Closed
wants to merge 5 commits into from
Closed

Add basic DDP #2

wants to merge 5 commits into from

Conversation

geekgonecrazy
Copy link

Current State

  • Establishes a connection using a component called <rocketchat-connection>
  • Loads 100 Messages from the single room history

Needs Improvement

  • I'm browserify + babel to create a ddp.js shim using cli instead of as part of a build process. browserify app/scripts/ddp.js -o app/scripts/iddp.js -t [ babelify --presets [ es2015 ] ]
  • Very reliant on gulp. Need to reduce.
  • Had to move away from <iron-list> because of the issue listed above. We need something like this for performance. It recycles DOM elements instead of creating new ones. (iron-list does not show all items on bound array change Polymer/polymer#3319 might be related)
  • Need to get room message subscription working.
  • Needs to get rooms from subscription instead of having to specify them.

Example of component

Currently the component takes room. Like mentioned in the needed improvements it should get this from the server or at least take an array

<rocketchat-connection url="wss://demo.rocket.chat" username="[email protected]" password="superpassword" room="GENERAL" messages="{{messages}}"></rocketchat-connection>

@geekgonecrazy
Copy link
Author

@dandv thoughts on this? Any tips or ideas on structuring this?

@Sing-Li
Copy link
Member

Sing-Li commented Apr 20, 2016

Refactored code into stand-alone, re-usable, web components

@Sing-Li
Copy link
Member

Sing-Li commented Apr 21, 2016

Add an iot canvas component for all the upcoming Maker Faires around the world early summer.

A special component for the Rocket.Chat on Raspberry Pi (RockOnPi) community.

Displays a PNG and allow "touch zones" to trigger SLASH CMDS sent to bots on a phone.

@geekgonecrazy
Copy link
Author

No longer really relevant :)

kamilkisiela referenced this pull request in kamilkisiela/Rocket.Chat.PWA Jul 21, 2017
@engelgabriel engelgabriel deleted the add-basic-ddp branch August 21, 2017 17:54
karlprieb pushed a commit that referenced this pull request Aug 22, 2017
karlprieb pushed a commit that referenced this pull request Jan 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants